Add contribution guidelines #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeySachkov
requested review from
bader,
svenvh,
AlexeySotkin and
AnastasiaStulova
svenvh
reviewed
Jul 3, 2020
There was a problem hiding this comment.
Thanks for doing this @AlexeySachkov !
This looks already quite complete to me, I just made various minor grammatical tweaks.
|
LGTM |
AlexeySachkov
force-pushed
the
private/asachkov/contribution-guidelines
branch
from
76f4e34
to
c908bdf
Compare
|
Amazing, thanks. |
|
Also tagging @Naghasan, @PawelJurek for code review and awareness |
|
LGTM, thanks |
Co-authored-by: Alexey Sotkin <alexey.sotkin@intel.com>
|
I've merged current version into the repo. If you have any additional feedback or other ideas about how to improve it, please either comment here or open a PR |
svenvh
pushed a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Nov 4, 2020
svenvh
pushed a commit
that referenced
this pull request
Nov 12, 2020
DmitryBushev
pushed a commit
to DmitryBushev/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any feedback/comments/suggestions are highly appreciated
TODO:
[ ] testing guidelines